diff --git a/skolehjem/app/Http/Controllers/UserController.php b/skolehjem/app/Http/Controllers/UserController.php index 7dd52d5..33ebb3f 100644 --- a/skolehjem/app/Http/Controllers/UserController.php +++ b/skolehjem/app/Http/Controllers/UserController.php @@ -71,15 +71,19 @@ class UserController extends Controller "phone" => "required|unique:users", ]); - $rolez = $request->input("roles", [ "User" ]); + if ($request->password != $request->password2) { + return redirect()->route('users.create')->with('error#notsamepass', '

Der stod ikke det samme i `Password` & `Confirm Password`!

'); + } + + $roles = $request->input("roles", [ "User" ]); $user = new User($data); - $user->assignRole($rolez); + $user->assignRole($roles); $user->save(); - return Response::detect("users.store"); + return redirect()->route('users.index'); } /** @@ -123,7 +127,6 @@ class UserController extends Controller */ public function update(Request $request, $id) { - return redirect()->route("users.account"); $user = User::find($id); if($id === Auth::id() || auth()->user()->hasPermissionTo("user.edit")) { @@ -134,7 +137,7 @@ class UserController extends Controller /** @var User $user */ $user->update($data); } else // Else go back with an error message - return redirect()->route("users.edit", ['user' => $id])->with('error#passnotsame', '

Der stod ikke det samme i `Password` & `Confirm Password`!

'); + return redirect()->route("users.edit", ['user' => $id])->with('error#notsamepass', '

Der stod ikke det samme i `Password` & `Confirm Password`!

'); } else { // If you haven't touched the password, then update everything else but password $data = $request->only(['name_first', 'name_last', 'email', 'phone', 'roles']); @@ -148,27 +151,6 @@ class UserController extends Controller foreach ($request->roles as $role) { $user->assignRole($role); } - } else { // Else if you're not on the admin site (user site) - if ($request->input('password') != null) { // If you're editing the password - $data = $request->only(['name_first', 'name_last', 'email', 'phone', 'password']); - if ($request->input('password') != $request->input('confirmpassword')) { // If new password and new password confirm is not the same, go back with fail message. - return redirect()->route("users.accounteditpass")->with('error#notsamepass', '

Der stod ikke det samme i `Nyt Password` & `Bekræft Nyt Password`!

'); - } elseif (!Hash::check($request->input('oldpassword'), $user->password)) { // If the written current password and current password in DB is not the same, go back with fail message. - return redirect()->route("users.accounteditpass")->with('error#oldpass', '

Det indtastede password i `Nuværende Password` er ikke dit nuværende password!

'); - } else { // If new password and current password is the same AND current written and current DB password is the same. Then update and logout. - /** @var User $user */ - $user->update($data); - Auth::logout(); - - return redirect()->route("users.login")->with('success#passwordchange', '

Dit password er hermed ændret!

'); - } - } else { // Else if you're not editing the password but anything else (Email, Phone Number). Then update user. - $data = $request->only(['email', 'phone']); - $user->update($data); - - return redirect()->route("users.account")->with('success#credentialschanged', '

Dine oplysninger er hermed ændret!

'); - } - } } $users = User::query()->paginate(20); @@ -274,7 +256,7 @@ class UserController extends Controller if ($request->input('password') != null) { // If you're editing the password $data = $request->only(['name_first', 'name_last', 'email', 'phone', 'password']); if ($request->input('password') != $request->input('confirmpassword')) { // If new password and new password confirm is not the same, go back with fail message. - return redirect()->route("users.accounteditpass")->with('error#notsamepass', '

Der stod ikke det samme i `Nyt Password` & `Bekræft Nyt Password`!

'); + return redirect()->route("users.accounteditpass")->with('error#notsamepass', '

Der stod ikke det samme i `Nyt Password` & `Confirm Password`!

'); } elseif (!Hash::check($request->input('oldpassword'), $user->password)) { // If the written current password and current password in DB is not the same, go back with fail message. return redirect()->route("users.accounteditpass")->with('error#oldpass', '

Det indtastede password i `Nuværende Password` er ikke dit nuværende password!

'); } else { // If new password and current password is the same AND current written and current DB password is the same. Then update and logout. diff --git a/skolehjem/resources/views/admin/users/create.blade.php b/skolehjem/resources/views/admin/users/create.blade.php index 0216fe0..e329ea1 100644 --- a/skolehjem/resources/views/admin/users/create.blade.php +++ b/skolehjem/resources/views/admin/users/create.blade.php @@ -11,6 +11,7 @@ @section("content")

Opret Bruger:

+ {!! session()->get('error#notsamepass') !!}
@csrf @@ -20,9 +21,15 @@ - - - +
+ + +
+ +
+ + +
@@ -36,3 +43,20 @@
@endsection + +@section("scripts") + +@endsection diff --git a/skolehjem/resources/views/admin/users/edit.blade.php b/skolehjem/resources/views/admin/users/edit.blade.php index b3feb3a..4559136 100644 --- a/skolehjem/resources/views/admin/users/edit.blade.php +++ b/skolehjem/resources/views/admin/users/edit.blade.php @@ -11,8 +11,8 @@ @section("content")

Rediger Bruger:

- {!! session()->get('error#passnotsame') !!} -
$user]) }}" style="display: inline-table;"> + {!! session()->get('error#notsamepass') !!} + $user]) }}"> @csrf @method("put") @@ -22,11 +22,15 @@ - - +
+ + +
- - +
+ + +
@@ -54,19 +58,6 @@
- @endsection @section("scripts") diff --git a/skolehjem/resources/views/app/users/editpass.blade.php b/skolehjem/resources/views/app/users/editpass.blade.php index bb0f78a..9497b5d 100644 --- a/skolehjem/resources/views/app/users/editpass.blade.php +++ b/skolehjem/resources/views/app/users/editpass.blade.php @@ -7,7 +7,7 @@ @section("content")

Konto

-
Auth::user()]) }}" style="display: inline-table;"> + Auth::user()]) }}"> @csrf @method("put") Nuværende Password: @@ -20,7 +20,7 @@ - Bekræft Nyt Password: + Confirm Password:
diff --git a/skolehjem/resources/views/app/users/login.blade.php b/skolehjem/resources/views/app/users/login.blade.php index e13dc07..8fddb85 100644 --- a/skolehjem/resources/views/app/users/login.blade.php +++ b/skolehjem/resources/views/app/users/login.blade.php @@ -12,7 +12,10 @@ @csrf - +
+ + +
@endsection + +@section("scripts") + +@endsection