bedder feedback on http response

Backend/Controllers/Admin/AdminLogin.php

@@ -19,18 +19,18 @@ if(isset($_POST['aLogin'])){
             $_SESSION['userName'] = $userName;
             $_SESSION['admin'] = true;
             $_SESSION['success'] = "You are now logged in";
-            echo http_response_code(200);
+            http_response_code(200);
         }else{
             session_destroy();
-            echo "Fail to verify password";
+            http_response_code(401);
-            echo http_response_code(401);
+            echo json_encode(["message" => "wrong password"]);
         }
 
     }else{
         session_destroy();
-        echo "No user";
+        http_response_code(401);
-        echo http_response_code(401);
+        echo json_encode(["message" => "admin don't exist"]);
     }
 }else{
-    echo http_response_code(400);
+    http_response_code(400);
 }

Backend/Controllers/Admin/AdminSignup.php

@@ -10,13 +10,14 @@ if (isAdmin()){
         $admin->user_name = $_POST["newUsername"];
         $admin->password = $_POST["newPassword"];
         if ($admin->save()){
-            echo http_response_code(201);
+            http_response_code(201);
         }else{
-            echo http_response_code(500);
+            http_response_code(500);
         }
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not admin"]);
 }

Backend/Controllers/FileHandler/FileHandler.php

@@ -15,14 +15,14 @@ function ZipFileHandler(string $gameFileName, string $gameFileTmp){
     if(in_array($headerType,$headerTypeMatch)){
         $gameFileNewName = uniqid("", true). "." .  $fileActualExtGame;
         if(empty($gameFileName)){
-            echo http_response_code(400);
+            http_response_code(400);
             exit();
         }
         rename($gameFileTmp,"../../Games/".$gameFileNewName);
         return $gameFileNewName;
     }else{
-        echo "Wrong file type";
+        http_response_code(400);
-        echo http_response_code(400);
+        echo json_encode(["message" => "Wrong file type gameFile"]);
         exit();
     }
 return NULL;
@@ -43,14 +43,14 @@ function imagesFileHandler(string $thumbnailFileName, string $thumbnailFileTmp){
     if(in_array($headerType,$headerTypeMatch)){
         $thumbnailFileNewName = uniqid("", true). "." .  $fileActualExtThumb;
         if(empty($thumbnailFileName)){
-            echo http_response_code(400);
+            http_response_code(400);
             exit();
         }
         rename($thumbnailFileTmp,"../../../Frontend/images/".$thumbnailFileNewName);
         return $thumbnailFileNewName;
     }else{
-        echo "Wrong file type";
+        http_response_code(400);
-        echo http_response_code(400);
+        echo json_encode(["message" => "Wrong file type thumbnailFile"]);
         exit();
     }
     return NULL;

Backend/Controllers/FileHandler/updateFiles.php

@@ -37,14 +37,15 @@ if(isLogin()){
         }
         $gameData->is_web_Based = $isWebBased;
         if(!$gameData->save()){
-           echo http_response_code(500);
+           http_response_code(500);
         }else{
-           echo http_response_code(201);
+           http_response_code(201);
         }
 
     }else{
-       echo http_response_code(400);
+       http_response_code(400);
     }
 }else{
-   echo http_response_code(401);
+   http_response_code(401);
+   echo json_encode(["message" => "is not login"]);
 }

Backend/Controllers/FileHandler/upload.php

@@ -53,23 +53,26 @@ if(isLogin()){
                     $gameData->save();
                     $group->gameData()->associate($gameData);
                    if(! $group->save()){
-                       echo http_response_code(500);
+                       http_response_code(500);
                    }else{
-                       echo http_response_code(201);
+                       http_response_code(201);
                    }
 
+                }else{
+                   http_response_code(500);
                 }
             }else{
-                echo http_response_code(400);
+                http_response_code(400);
             }
         }else{
-            echo "Can only upload one file";
+            http_response_code(400);
-            echo http_response_code(400);
+            echo json_encode(["message" => "Can only upload one file"]);
         }
     }else{
-        echo "Can only upload when the game jam has started";
+        http_response_code(400);
-        echo http_response_code(400);
+        echo json_encode(["message" => "Can only upload when the game jam has started"]);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not login"]);
 }

Backend/Controllers/GameJam/NewGameJam.php

@@ -17,14 +17,15 @@ if(isAdmin()){
         $gameJam->description = $_POST["description"];
 
         if($gameJam->save()){
-            echo http_response_code(201);
+            http_response_code(201);
         }
         else{
-            echo http_response_code(500);
+            http_response_code(500);
         }
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not admin"]);
 }

Backend/Controllers/GameJam/UpdateGameJam.php

@@ -22,14 +22,18 @@ if(isAdmin()){
 
             $gameJam->description = $_POST['description'];
             if ($gameJam->save()) {
-                echo http_response_code(201);
+                http_response_code(201);
             }else{
-                echo http_response_code(500);
+                http_response_code(500);
             }
+        }else{
+            http_response_code(400);
+            echo json_encode(["message" => "game jam not found"]);
         }
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not admin"]);
 }

Backend/Controllers/Group/Login.php

@@ -27,26 +27,26 @@ if(isset($_POST['login'])){
                $_SESSION['success'] = "You are now logged in";
                //header('location:  ../../../Frontend/index.php?login=success');
                //exit();
-               echo http_response_code(200);
+               http_response_code(200);
            }
            else{
                session_destroy();
-               echo http_response_code(500);
+               http_response_code(500);
            }
 
        }else{
            session_destroy();
-           echo "Wrong password";
+           http_response_code(401);
-           echo http_response_code(401);
+           echo json_encode(["message" => "Wrong password"]);
        }
 
    }else{
        session_destroy();
-       echo "group was not found";
+       http_response_code(401);
-       echo http_response_code(401);
+       echo json_encode(["message" => "group was not found"]);
    }
 
 
 }else{
-    echo http_response_code(400);
+    http_response_code(400);
 }

Backend/Controllers/Group/ResetPassword.php

@@ -12,17 +12,19 @@ if(isAdmin()){
             $password->password =  password_hash($_POST['newPassword'], PASSWORD_DEFAULT);
             echo $password;
             if(!$password->save()){
-                echo http_response_code(500);
+                http_response_code(500);
             }else{
-                echo http_response_code(201);
+                http_response_code(201);
             }
         }else{
-            echo http_response_code(400);
+            http_response_code(400);
+            echo json_encode(["message" => "group not found"]);
         }
 
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not admin"]);
 }

Backend/Controllers/Group/SigningUp.php

@@ -24,8 +24,10 @@ if(isset($_POST['regGroup'])){
         $group->group_amount = $_POST['groupAmount'];
 
         if(!$group->save()){
-            return;
+            http_response_code(500);
+            exit();
         }
+
         $password = New Password();
 
         $password->group()->associate($group);
@@ -37,18 +39,20 @@ if(isset($_POST['regGroup'])){
         $password->remember_token = $token;
 
         if(!$password->save()){
-            echo http_response_code(500);
+            http_response_code(500);
-        }else{
+            exit();
-            echo http_response_code(201);
         }
 
         $_SESSION['groupName'] = $groupName;
         $_SESSION['token'] = $token;
         $_SESSION['success'] = "You are now logged in";
+        http_response_code(201);
+        echo json_encode(["message" => "you are login"]);
 
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
+        echo json_encode(["message" => "password not valid"]);
     }
 }else{
-    echo http_response_code(400);
+    http_response_code(400);
 }

Backend/Controllers/Group/UpdateGruop.php

@@ -11,16 +11,21 @@ if(isLogin()){
                 $group->group_amount = $_POST['groupAmount'];
                 $group->game_jam_id = $_POST['gameJamId'];
                 if(!$group->save()){
-                    echo http_response_code(500);
+                    http_response_code(500);
                 }else{
-                    echo http_response_code(201);
+                    http_response_code(201);
                 }
         }
+        else{
+            http_response_code(400);
+            echo json_encode(["message" => "group not found"]);
+        }
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not login"]);
 }
 
 

Backend/Controllers/Group/UpdatePassword.php

@@ -9,15 +9,20 @@ if(isLogin()){
         if(passwordValidate($pass = $_POST['password'])){
             $password->password = password_hash($pass,PASSWORD_DEFAULT);
             if(!$password->save()){
-                echo http_response_code(500);
+                http_response_code(500);
             }else{
-                echo http_response_code(201);
+                http_response_code(201);
             }
         }
+        else{
+            http_response_code(400);
+            echo json_encode(["message" => "password not valid"]);
+        }
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not login"]);
 }

Backend/Controllers/Polls/1vote.php

@@ -20,9 +20,13 @@ if(isset($_POST['1Vote'])){
         }else{
             http_response_code(201);
         }
+    } else{
+        http_response_code(403);
+        echo json_encode(["message" => "you have already voted"]);
     }
 }else{
-    echo http_response_code(400);
+    http_response_code(400);
+    echo json_encode(["message" => "you have already voted"]);
 }
 
 

Backend/Controllers/Polls/GetVote.php

@@ -8,5 +8,6 @@ if(isLogin()){
     echo json_encode(array('data' => Vote::where('group_id',groupViaToken($_SESSION['token'])->id)->get()->jsonSerialize()));
 
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "not login"]);
 }

Backend/Controllers/Polls/GetWinner.php

@@ -5,30 +5,39 @@ use Backend\Models\Group;
 use Backend\Models\Vote;
 use \Illuminate\Support\Collection;
 
-if(isAdmin() && isset($_GET['gameJamId'])){
+if(isAdmin()){
-    $groups = Group::where('game_jam_id',$_GET['gameJamId'])->get();
+    if(isset($_GET['gameJamId'])) {
-    $winningGroups = new Collection();
+        $groups = Group::where('game_jam_id', $_GET['gameJamId'])->get();
-    $i = -1;
+        if($groups) {
-    foreach ($groups as $group){
-        $x = Vote::where('group_id', $group->id)->count();
-        if($x>$i){
             $winningGroups = new Collection();
-            $winningGroups->push($group);
+            $i = -1;
+            foreach ($groups as $group) {
+                $x = Vote::where('group_id', $group->id)->count();
+                if ($x > $i) {
+                    $winningGroups = new Collection();
+                    $winningGroups->push($group);
 
-            $i = $x;
+                    $i = $x;
+                } elseif ($i === $x) {
+                    $winningGroups->push($group);
+                }
+            }
+
+            header("Access-Control-Allow-Methods: GET");
+            header("Access-Control-Allow-Headers: X-Requested-With, Content-Type, Accept");
+            header('Content-Type: application/json;charset=UTF-8');
+            echo json_encode(array('data' => $winningGroups->jsonSerialize()));
         }
-        elseif ($i === $x){
+        else{
-            $winningGroups->push($group);
+            http_response_code(400);
+            echo json_encode(["message" => "game jam not found"]);
         }
+    }else{
+        http_response_code(400);
     }
 
-    header("Access-Control-Allow-Methods: GET");
-    header("Access-Control-Allow-Headers: X-Requested-With, Content-Type, Accept");
-    header('Content-Type: application/json;charset=UTF-8');
-    echo json_encode(array('data' => $winningGroups->jsonSerialize()));
-
-
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "not admin"]);
 }
 

Backend/Controllers/keyWord/GetKeyWinner.php

@@ -25,8 +25,9 @@ if (!isAdmin()){
         header('Content-Type: application/json;charset=UTF-8');
         echo json_encode(array('data' => $find_all_keywords->jsonSerialize()));
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "is not admin"]);
 }

Backend/Controllers/keyWord/NewKeyWord.php

@@ -25,19 +25,20 @@ if (isLogin()) {
 
             //Try to save it
             if(!$keyword->save()){
-                echo http_response_code(500);
+                http_response_code(500);
             }else{
-                echo http_response_code(201);
+                http_response_code(201);
             }
         }else{
-            echo "limited upload reached";
+            http_response_code(400);
-            echo http_response_code(400);
+            echo json_encode(["message" => "limited upload reached"]);
         }
 
     }else{
-        echo http_response_code(400);
+        http_response_code(400);
     }
 }else{
-    echo http_response_code(401);
+    http_response_code(401);
+    echo json_encode(["message" => "not login"]);
 }